Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56543af9 authored by Akinobu Mita's avatar Akinobu Mita Committed by David S. Miller
Browse files

starfire: use BUILD_BUG_ON for netdrv_addr_t 



Detect size mismatch for netdrv_addr_t at build time rather than
checking at module load time.

Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Cc: Ion Badulescu <ionut@badula.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d08336e9

drivers/net/starfire.c

+1 −5
Original line number Diff line number Diff line
@@ -2078,11 +2078,7 @@ static int __init starfire_init (void) 
	printk(KERN_INFO DRV_NAME ": polling (NAPI) enabled\n");

#endif



	/* we can do this test only at run-time... sigh */

	if (sizeof(dma_addr_t) != sizeof(netdrv_addr_t)) {

		printk("This driver has dma_addr_t issues, please send email to maintainer\n");

		return -ENODEV;

	}

	BUILD_BUG_ON(sizeof(dma_addr_t) != sizeof(netdrv_addr_t));



	return pci_register_driver(&starfire_driver);

}