Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 561ed233 authored by Wu Fengguang's avatar Wu Fengguang Committed by David S. Miller
Browse files

qed: fix kzalloc-simple.cocci warnings 



drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1230:13-20: WARNING: kzalloc should be used for dcbx_info, instead of kmalloc/memset
drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1192:13-20: WARNING: kzalloc should be used for dcbx_info, instead of kmalloc/memset

 Use kzalloc rather than kmalloc followed by memset with 0

 This considers some simple cases that are common and easy to validate
 Note in particular that there are no ...s in the rule, so all of the
 matched code has to be contiguous

Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci

CC: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
Signed-off-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Acked-by: default avatarYuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cb849e30

drivers/net/ethernet/qlogic/qed/qed_dcbx.c

+2 −4
Original line number Diff line number Diff line
@@ -1189,13 +1189,12 @@ int qed_dcbx_get_config_params(struct qed_hwfn *p_hwfn, 
		return 0;

	}



	dcbx_info = kmalloc(sizeof(*dcbx_info), GFP_KERNEL);

	dcbx_info = kzalloc(sizeof(*dcbx_info), GFP_KERNEL);

	if (!dcbx_info) {

		DP_ERR(p_hwfn, "Failed to allocate struct qed_dcbx_info\n");

		return -ENOMEM;

	}



	memset(dcbx_info, 0, sizeof(*dcbx_info));

	rc = qed_dcbx_query_params(p_hwfn, dcbx_info, QED_DCBX_OPERATIONAL_MIB);

	if (rc) {

		kfree(dcbx_info);
@@ -1227,13 +1226,12 @@ static struct qed_dcbx_get *qed_dcbnl_get_dcbx(struct qed_hwfn *hwfn, 
{

	struct qed_dcbx_get *dcbx_info;



	dcbx_info = kmalloc(sizeof(*dcbx_info), GFP_KERNEL);

	dcbx_info = kzalloc(sizeof(*dcbx_info), GFP_KERNEL);

	if (!dcbx_info) {

		DP_ERR(hwfn->cdev, "Failed to allocate memory for dcbx_info\n");

		return NULL;

	}



	memset(dcbx_info, 0, sizeof(*dcbx_info));

	if (qed_dcbx_query_params(hwfn, dcbx_info, type)) {

		kfree(dcbx_info);

		return NULL;