Commit 54bcfdf1 authored Nov 04, 2015 by Markus Elfring Committed by Richard Weinberger Nov 06, 2015

UBIFS: Delete unnecessary checks before the function call "iput"



The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Richard Weinberger <richard@nod.at>

parent a396ce4b

fs/ubifs/recovery.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1331,7 +1331,6 @@ void ubifs_destroy_size_tree(struct ubifs_info *c)
		struct size_entry e, n;

		rbtree_postorder_for_each_entry_safe(e, n, &c->size_tree, rb) {
		if (e->inode)
		iput(e->inode);
		kfree(e);
		}
		@@ -1533,7 +1532,6 @@ int ubifs_recover_size(struct ubifs_info *c)
		err = fix_size_in_place(c, e);
		if (err)
		return err;
		if (e->inode)
		iput(e->inode);
		}
		}