Commit 53653c6b authored Dec 21, 2015 by Stefan Wahren Committed by Linus Walleij Dec 22, 2015

pinctrl: bcm2835: Fix memory leak in error path



In case of an invalid pin value bcm2835_pctl_dt_node_to_map()
would leak the pull configs of already assigned pins.
So avoid this by calling the free map function in error case.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Fixes: e1b2dc70 ("pinctrl: add bcm2835 driver")
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 4fc8a4b2

drivers/pinctrl/bcm/pinctrl-bcm2835.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -794,7 +794,7 @@ static int bcm2835_pctl_dt_node_to_map(struct pinctrl_dev *pctldev,
		return 0;

		out:
		kfree(maps);
		bcm2835_pctl_dt_free_map(pctldev, maps, num_pins * maps_per_pin);
		return err;
		}