Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52a1020e authored by David Herrmann's avatar David Herrmann Committed by Gustavo Padovan
Browse files

Bluetooth: ath3k: Use GFP_KERNEL instead of GFP_ATOMIC 



We are allowed to sleep here so no need to use GFP_ATOMIC. The caller
(ath3k_probe) calls request_firmware() which definitely sleeps. Hence, we should
avoid using GFP_ATOMIC.

Signed-off-by: default avatarDavid Herrmann <dh.herrmann@googlemail.com>
Signed-off-by: default avatarGustavo F. Padovan <padovan@profusion.mobi>
parent df164df9

drivers/bluetooth/ath3k.c

+2 −2
Original line number Diff line number Diff line
@@ -106,7 +106,7 @@ static int ath3k_load_firmware(struct usb_device *udev, 


	pipe = usb_sndctrlpipe(udev, 0);



	send_buf = kmalloc(BULK_SIZE, GFP_ATOMIC);

	send_buf = kmalloc(BULK_SIZE, GFP_KERNEL);

	if (!send_buf) {

		BT_ERR("Can't allocate memory chunk for firmware");

		return -ENOMEM;
@@ -177,7 +177,7 @@ static int ath3k_load_fwfile(struct usb_device *udev, 


	count = firmware->size;



	send_buf = kmalloc(BULK_SIZE, GFP_ATOMIC);

	send_buf = kmalloc(BULK_SIZE, GFP_KERNEL);

	if (!send_buf) {

		BT_ERR("Can't allocate memory chunk for firmware");

		return -ENOMEM;