Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52565544 authored by Divy Le Ray's avatar Divy Le Ray Committed by David S. Miller
Browse files

cxgb3: avoid potential memory leak. 



Add consistency in alloc_ring() parameter checking
to avoid potential memory leaks.
alloc_ring() callers are correct fo far.

Signed-off-by: default avatarDivy Le Ray <divy@chelsio.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 43a944f3

drivers/net/cxgb3/sge.c

+2 −3
Original line number Diff line number Diff line
@@ -549,16 +549,15 @@ static void *alloc_ring(struct pci_dev *pdev, size_t nelem, size_t elem_size, 


	if (!p)

		return NULL;

	if (sw_size) {

	if (sw_size && metadata) {

		s = kcalloc(nelem, sw_size, GFP_KERNEL);



		if (!s) {

			dma_free_coherent(&pdev->dev, len, p, *phys);

			return NULL;

		}

	}

	if (metadata)

		*(void **)metadata = s;

	}

	memset(p, 0, len);

	return p;

}