Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5219a534 authored by Steffen Klassert's avatar Steffen Klassert Committed by Herbert Xu
Browse files

crypto: user - Fix size of netlink dump message 



The default netlink message size limit might be exceeded when dumping a
lot of algorithms to userspace. As a result, not all of the instantiated
algorithms dumped to userspace. So calculate an upper bound on the message
size and call netlink_dump_start() with that value.

Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 1e122994

crypto/crypto_user.c

+8 −0
Original line number Diff line number Diff line
@@ -457,12 +457,20 @@ static int crypto_user_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh) 


	if ((type == (CRYPTO_MSG_GETALG - CRYPTO_MSG_BASE) &&

	    (nlh->nlmsg_flags & NLM_F_DUMP))) {

		struct crypto_alg *alg;

		u16 dump_alloc = 0;



		if (link->dump == NULL)

			return -EINVAL;



		list_for_each_entry(alg, &crypto_alg_list, cra_list)

			dump_alloc += CRYPTO_REPORT_MAXSIZE;



		{

			struct netlink_dump_control c = {

				.dump = link->dump,

				.done = link->done,

				.min_dump_alloc = dump_alloc,

			};

			return netlink_dump_start(crypto_nlsk, skb, nlh, &c);

		}

include/linux/cryptouser.h

+3 −0
Original line number Diff line number Diff line
@@ -100,3 +100,6 @@ struct crypto_report_rng { 
	char type[CRYPTO_MAX_NAME];

	unsigned int seedsize;

};



#define CRYPTO_REPORT_MAXSIZE (sizeof(struct crypto_user_alg) + \

			       sizeof(struct crypto_report_blkcipher))