Commit 51e81656 authored Mar 21, 2011 by Jesper Juhl Committed by Trond Myklebust Mar 22, 2011

Remove pointless memset in nfsacl_encode()



Remove pointless memset() in nfsacl_encode().

Thanks to Trond Myklebust <Trond.Myklebust@netapp.com> for pointing out
that it is not needed since posix_acl_init() will set everything
regardless..

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent 4667058b

fs/nfs_common/nfsacl.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -117,7 +117,6 @@ int nfsacl_encode(struct xdr_buf buf, unsigned int base, struct inode inode,
		* invoked in contexts where a memory allocation failure is
		* fatal. Fortunately this fake ACL is small enough to
		* construct on the stack. */
		memset(acl2, 0, sizeof(acl2));
		posix_acl_init(acl2, 4);

		/* Insert entries in canonical order: other orders seem