Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 51a3ac5f authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Mauro Carvalho Chehab
Browse files

[media] c8sectpfe: fix return of garbage 



The variable err was never initialized, that means we had been checking
a garbage value in the for loop. Moreover if the segment is not outside
the firmware file then also we have been returning the garbage.
Initialize it to 0 so that on success we return the value and no need to
check in the for loop also as it is initially 0 and whenever that value
changes we have done a break from the loop.

Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent bf447221

drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c

+2 −2
Original line number Diff line number Diff line
@@ -1097,7 +1097,7 @@ static int load_slim_core_fw(const struct firmware *fw, void *context) 
	Elf32_Ehdr *ehdr;

	Elf32_Phdr *phdr;

	u8 __iomem *dst;

	int err, i;

	int err = 0, i;



	if (!fw || !context)

		return -EINVAL;
@@ -1106,7 +1106,7 @@ static int load_slim_core_fw(const struct firmware *fw, void *context) 
	phdr = (Elf32_Phdr *)(fw->data + ehdr->e_phoff);



	/* go through the available ELF segments */

	for (i = 0; i < ehdr->e_phnum && !err; i++, phdr++) {

	for (i = 0; i < ehdr->e_phnum; i++, phdr++) {



		/* Only consider LOAD segments */

		if (phdr->p_type != PT_LOAD)