Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5104a03d authored by YOSHIFUJI Hideaki's avatar YOSHIFUJI Hideaki Committed by Stefan Richter
Browse files

firewire net: No need to reset dev->local_fifo after failure of fw_core_add_address_handler(). 



fwnet_broadcast_start() try to register address handler at first
if it was not registered yet; dev->local_fifo ==
FWNET_NO_FIFO_ADDR.

Since dev->local_info not changed if fw_core_add_address_hander()
has failed, we do not need to set dev->local_info to
FWNET_NO_FIFO_ADDR.

Signed-off-by: default avatarYOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent 6dbe51c2

drivers/firewire/net.c

+1 −1
Original line number Diff line number Diff line
@@ -1220,8 +1220,8 @@ static int fwnet_broadcast_start(struct fwnet_device *dev) 
	dev->broadcast_rcv_context = NULL;

 failed_context_create:

	fw_core_remove_address_handler(&dev->handler);

 failed_initial:

	dev->local_fifo = FWNET_NO_FIFO_ADDR;

 failed_initial:



	return retval;

}