Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50f07596 authored by Mark Brown's avatar Mark Brown Committed by Liam Girdwood
Browse files

regulator: Don't increment use_count for boot_on regulators



Don't set use_count for regulators that are enabled at boot since this
stops the supply being disabled by well-behaved consumers which do
balanced enables and disabled. Any consumers which don't do disables
which are not matched by enables are unable to share regulators - shared
regulators are the common case so the API should facilitate them.

Consumers that want to disable regulators that are enabled when they
start have two options:

 - Do a regulator_enable() prior to the disable to bring the use count
   in sync with the hardware state; this will ensure that if the
   regulator was enabled by another driver then this consumer will play
   nicely with it.
 - Use regulator_force_disable(); this explicitly bypasses any checks
   done by the core and documents the inability of the driver to share
   the supply.

Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
parent 52914eaa
Loading
Loading
Loading
Loading
+0 −1
Original line number Diff line number Diff line
@@ -814,7 +814,6 @@ static int set_machine_constraints(struct regulator_dev *rdev,
			rdev->constraints = NULL;
			goto out;
		}
		rdev->use_count = 1;
	}

	print_constraints(rdev);