Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50d60c63 authored by Fengguang Wu's avatar Fengguang Wu Committed by John W. Linville
Browse files

wcn36xx: fix coccinelle warnings 



drivers/net/wireless/ath/wcn36xx/debug.c:27:11-31: WARNING opportunity for simple_open, see also structure on line 106
/c/kernel-tests/src/i386/drivers/net/wireless/ath/wcn36xx/debug.c:27:11-31: WARNING opportunity for simple_open, see also structure on line 148

 This removes an open coded simple_open() function
 and replaces file operations references to the function
 with simple_open() instead.

Generated by: coccinelle/api/simple_open.cocci

CC: Eugene Krasnikov <k.eugene.e@gmail.com>
CC: John W. Linville <linville@tuxdriver.com>
Signed-off-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 7e43f3b0

drivers/net/wireless/ath/wcn36xx/debug.c

+2 −9
Original line number Diff line number Diff line
@@ -24,13 +24,6 @@ 


#ifdef CONFIG_WCN36XX_DEBUGFS



static int wcn36xx_debugfs_open(struct inode *inode, struct file *file)

{

	file->private_data = inode->i_private;



	return 0;

}



static ssize_t read_file_bool_bmps(struct file *file, char __user *user_buf,

				   size_t count, loff_t *ppos)

{
@@ -103,7 +96,7 @@ static ssize_t write_file_bool_bmps(struct file *file, 
}



static const struct file_operations fops_wcn36xx_bmps = {

	.open  =       wcn36xx_debugfs_open,

	.open = simple_open,

	.read  =       read_file_bool_bmps,

	.write =       write_file_bool_bmps,

};
@@ -145,7 +138,7 @@ static ssize_t write_file_dump(struct file *file, 
}



static const struct file_operations fops_wcn36xx_dump = {

	.open  =       wcn36xx_debugfs_open,

	.open = simple_open,

	.write =       write_file_dump,

};