Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50d2bdb1 authored Nov 01, 2012 by Weston Andros Adamson Committed by Trond Myklebust Nov 04, 2012

SUNRPC: remove BUG_ON from rpc_call_sync



Use WARN_ON_ONCE instead of calling BUG_ON and return -EINVAL when
RPC_TASK_ASYNC flag is passed to rpc_call_sync.

Signed-off-by: Weston Andros Adamson <dros@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent 0a0c2a57

net/sunrpc/clnt.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -842,7 +842,12 @@ int rpc_call_sync(struct rpc_clnt clnt, const struct rpc_message msg, int flag
		};
		int status;

		BUG_ON(flags & RPC_TASK_ASYNC);
		WARN_ON_ONCE(flags & RPC_TASK_ASYNC);
		if (flags & RPC_TASK_ASYNC) {
		rpc_release_calldata(task_setup_data.callback_ops,
		task_setup_data.callback_data);
		return -EINVAL;
		}

		task = rpc_run_task(&task_setup_data);
		if (IS_ERR(task))