Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5042f936 authored by Sjoerd Simons's avatar Sjoerd Simons Committed by Mark Brown
Browse files

ASoC: rockchip: spdif: Set transmit data level to 16 samples 



Explicitly set the transmit data level on the transceiver to 16 samples
rather then the default 0. This matches both the level set in the vendor
kernel and the (seemingly very similar) i2s engine. This fixes audio
glitches when playing back at 192k rate.

At the same time, fix a trivial typo in the TDL mask definition

Signed-off-by: default avatarSjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 8005c49d

sound/soc/rockchip/rockchip_spdif.c

+4 −2
Original line number Diff line number Diff line
@@ -152,8 +152,10 @@ static int rk_spdif_trigger(struct snd_pcm_substream *substream, 
	case SNDRV_PCM_TRIGGER_RESUME:

	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:

		ret = regmap_update_bits(spdif->regmap, SPDIF_DMACR,

				   SPDIF_DMACR_TDE_ENABLE,

				   SPDIF_DMACR_TDE_ENABLE);

				   SPDIF_DMACR_TDE_ENABLE |

				   SPDIF_DMACR_TDL_MASK,

				   SPDIF_DMACR_TDE_ENABLE |

				   SPDIF_DMACR_TDL(16));



		if (ret != 0)

			return ret;

sound/soc/rockchip/rockchip_spdif.h

+1 −1
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ 


#define SPDIF_DMACR_TDL_SHIFT	0

#define SPDIF_DMACR_TDL(x)	((x) << SPDIF_DMACR_TDL_SHIFT)

#define SPDIF_DMACR_TDL_MASK	(0x1f << SDPIF_DMACR_TDL_SHIFT)

#define SPDIF_DMACR_TDL_MASK	(0x1f << SPDIF_DMACR_TDL_SHIFT)



/*

 * XFER