Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4fae4e76 authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Thomas Gleixner
Browse files

irq: Warn when shared interrupts do not match on NO_SUSPEND 



When suspend_device_irqs() iterates all descriptors, its pointless if
one has NO_SUSPEND set while another has not.

Validate on request_irq() that NO_SUSPEND state maches for SHARED
interrupts.

Signed-off-by: default avatarPeter Zijlstra <peterz@infradead.org>
Acked-by: default avatar"Rafael J. Wysocki" <rjw@rjwysocki.net>
Link: http://lkml.kernel.org/r/20140724133921.GY6758@twins.programming.kicks-ass.net


Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 1b073383

kernel/irq/manage.c

+5 −2
Original line number Diff line number Diff line
@@ -1077,9 +1077,12 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) 
		 * set the trigger type must match. Also all must

		 * agree on ONESHOT.

		 */



#define IRQF_MISMATCH \

	(IRQF_TRIGGER_MASK | IRQF_ONESHOT | IRQF_NO_SUSPEND)



		if (!((old->flags & new->flags) & IRQF_SHARED) ||

		    ((old->flags ^ new->flags) & IRQF_TRIGGER_MASK) ||

		    ((old->flags ^ new->flags) & IRQF_ONESHOT))

		    ((old->flags ^ new->flags) & IRQF_MISMATCH))

			goto mismatch;



		/* All handlers must agree on per-cpuness */