Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f93b3e8 authored by Oliver Neukum's avatar Oliver Neukum Committed by Greg Kroah-Hartman
Browse files

USB: omninet memory leak in error case 



memory allocated must be freed in the error case.

Signed-off-by: default avatarOliver Neukum <oneukum@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 0cef7727

drivers/usb/serial/omninet.c

+5 −1
Original line number Original line Diff line number Diff line
@@ -170,8 +170,12 @@ static int omninet_open (struct usb_serial_port *port, struct file *filp) 
		      port->read_urb->transfer_buffer, port->read_urb->transfer_buffer_length,

		      port->read_urb->transfer_buffer, port->read_urb->transfer_buffer_length,

		      omninet_read_bulk_callback, port);

		      omninet_read_bulk_callback, port);

	result = usb_submit_urb(port->read_urb, GFP_KERNEL);

	result = usb_submit_urb(port->read_urb, GFP_KERNEL);

	if (result)

	if (result) {

		err("%s - failed submitting read urb, error %d", __FUNCTION__, result);

		err("%s - failed submitting read urb, error %d", __FUNCTION__, result);

		/* open failed - all allocations must be freed */

		kfree(od);

		usb_set_serial_port_data(port, NULL);

	}





	return result;

	return result;

}

}