Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f765482 authored by Michael Hennerich's avatar Michael Hennerich Committed by Greg Kroah-Hartman
Browse files

staging: iio: dac: ad5446: Remove unused sign member from chip specific information structure 



Remove unused sign member from chip specific information structure
Fix typos

Signed-off-by: default avatarMichael Hennerich <michael.hennerich@analog.com>
Acked-by: default avatarJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent d846263d

drivers/staging/iio/dac/ad5446.c

+0 −10
Original line number Diff line number Diff line
@@ -118,35 +118,30 @@ static const struct ad5446_chip_info ad5446_chip_info_tbl[] = { 
		.bits = 12,

		.storagebits = 16,

		.left_shift = 2,

		.sign = 'u', /* IIO_SCAN_EL_TYPE_UNSIGNED */

		.store_sample = ad5446_store_sample,

	},

	[ID_AD5446] = {

		.bits = 14,

		.storagebits = 16,

		.left_shift = 0,

		.sign = 'u', /* IIO_SCAN_EL_TYPE_UNSIGNED */

		.store_sample = ad5446_store_sample,

	},

	[ID_AD5542A] = {

		.bits = 16,

		.storagebits = 16,

		.left_shift = 0,

		.sign = 'u', /* IIO_SCAN_EL_TYPE_UNSIGNED */

		.store_sample = ad5542_store_sample,

	},

	[ID_AD5512A] = {

		.bits = 12,

		.storagebits = 16,

		.left_shift = 4,

		.sign = 'u', /* IIO_SCAN_EL_TYPE_UNSIGNED */

		.store_sample = ad5542_store_sample,

	},

	[ID_AD5620_2500] = {

		.bits = 12,

		.storagebits = 16,

		.left_shift = 2,

		.sign = 'u', /* IIO_SCAN_EL_TYPE_UNSIGNED */

		.int_vref_mv = 2500,

		.store_sample = ad5620_store_sample,

	},
@@ -154,7 +149,6 @@ static const struct ad5446_chip_info ad5446_chip_info_tbl[] = { 
		.bits = 12,

		.storagebits = 16,

		.left_shift = 2,

		.sign = 'u', /* IIO_SCAN_EL_TYPE_UNSIGNED */

		.int_vref_mv = 1250,

		.store_sample = ad5620_store_sample,

	},
@@ -162,7 +156,6 @@ static const struct ad5446_chip_info ad5446_chip_info_tbl[] = { 
		.bits = 14,

		.storagebits = 16,

		.left_shift = 0,

		.sign = 'u', /* IIO_SCAN_EL_TYPE_UNSIGNED */

		.int_vref_mv = 2500,

		.store_sample = ad5620_store_sample,

	},
@@ -170,7 +163,6 @@ static const struct ad5446_chip_info ad5446_chip_info_tbl[] = { 
		.bits = 14,

		.storagebits = 16,

		.left_shift = 0,

		.sign = 'u', /* IIO_SCAN_EL_TYPE_UNSIGNED */

		.int_vref_mv = 1250,

		.store_sample = ad5620_store_sample,

	},
@@ -178,7 +170,6 @@ static const struct ad5446_chip_info ad5446_chip_info_tbl[] = { 
		.bits = 16,

		.storagebits = 24,

		.left_shift = 0,

		.sign = 'u', /* IIO_SCAN_EL_TYPE_UNSIGNED */

		.int_vref_mv = 2500,

		.store_sample = ad5660_store_sample,

	},
@@ -186,7 +177,6 @@ static const struct ad5446_chip_info ad5446_chip_info_tbl[] = { 
		.bits = 16,

		.storagebits = 24,

		.left_shift = 0,

		.sign = 'u', /* IIO_SCAN_EL_TYPE_UNSIGNED */

		.int_vref_mv = 1250,

		.store_sample = ad5660_store_sample,

	},

drivers/staging/iio/dac/ad5446.h

+2 −4
Original line number Diff line number Diff line
@@ -56,20 +56,18 @@ struct ad5446_state { 
};



/**

 * struct ad5446_chip_info - chip specifc information

 * struct ad5446_chip_info - chip specific information

 * @bits:		accuracy of the DAC in bits

 * @storagebits:	number of bits written to the DAC

 * @left_shift:		number of bits the datum must be shifted

 * @sign:		data representation [s]igned or [u]nsigned

 * @int_vref_mv:	AD5620/40/60: the internal reference voltage

 * @store_sample:	chip specifc helper function to store the datum

 * @store_sample:	chip specific helper function to store the datum

 */



struct ad5446_chip_info {

	u8				bits;

	u8				storagebits;

	u8				left_shift;

	char				sign;

	u16				int_vref_mv;

	void (*store_sample)		(struct ad5446_state *st, unsigned val);

};