Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f4bde1d authored by Jean-Jacques Hiblot's avatar Jean-Jacques Hiblot Committed by Bjorn Helgaas
Browse files

PCI: mvebu: Fix potential issue in range parsing 



The second parameter of of_read_number() is not the index, but a size.  As
it happens, in this case it may work just fine because of the conversion to
u32 and the favorable endianness on this architecture.

Fixes: 11be6547 ("PCI: mvebu: Adapt to the new device tree layout")
Tested-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: default avatarJean-Jacques Hiblot <jjhiblot@traphandler.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: default avatarJason Cooper <jason@lakedaemon.net>
Cc: stable@vger.kernel.org	# v3.12+
parent a760d2fb

drivers/pci/host/pci-mvebu.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -797,7 +797,7 @@ static int mvebu_get_tgt_attr(struct device_node *np, int devfn, 




	for (i = 0; i < nranges; i++) {

	for (i = 0; i < nranges; i++) {

		u32 flags = of_read_number(range, 1);

		u32 flags = of_read_number(range, 1);

		u32 slot = of_read_number(range, 2);

		u32 slot = of_read_number(range + 1, 1);

		u64 cpuaddr = of_read_number(range + na, pna);

		u64 cpuaddr = of_read_number(range + na, pna);

		unsigned long rtype;

		unsigned long rtype;