Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ed60fc2 authored by Peter Hurley's avatar Peter Hurley Committed by Greg Kroah-Hartman
Browse files

pty: Hold ctrl_lock for packet mode updates 



Updates to the packet mode enable require holding the ctrl_lock;
the serialization prevents corruption of adjacent fields.

Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
Reviewed-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2622d73e

drivers/tty/pty.c

+2 −0
Original line number Diff line number Diff line
@@ -47,7 +47,9 @@ static void pty_close(struct tty_struct *tty, struct file *filp) 
	set_bit(TTY_IO_ERROR, &tty->flags);

	wake_up_interruptible(&tty->read_wait);

	wake_up_interruptible(&tty->write_wait);

	spin_lock_irq(&tty->ctrl_lock);

	tty->packet = 0;

	spin_unlock_irq(&tty->ctrl_lock);

	/* Review - krefs on tty_link ?? */

	if (!tty->link)

		return;