Commit 4eb313a7 authored Jun 21, 2013 by Sergei Shtylyov Committed by David S. Miller Jun 24, 2013

sh_eth: fix misreporting of transmit abort

Due to obviously missing braces, EESR.TABT (transmit abort) interrupt may be
reported even if it hasn't happened, just when EESR.TWB (transmit descriptor
write-back) interrupt happens. Luckily (?), EESR.TWB is disabled by the driver
via the TRIMD register and all the interrupt masks, so that transmit abort is
never actually logged...

Put the braces where they should be and fix the incoherent comment, while at it.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ca8c3585

drivers/net/ethernet/renesas/sh_eth.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1552,12 +1552,13 @@ static void sh_eth_error(struct net_device *ndev, int intr_status)

		ignore_link:
		if (intr_status & EESR_TWB) {
		/* Write buck end. unused write back interrupt */
		if (intr_status & EESR_TABT) /* Transmit Abort int */
		/* Unused write back interrupt */
		if (intr_status & EESR_TABT) { /* Transmit Abort int */
		ndev->stats.tx_aborted_errors++;
		if (netif_msg_tx_err(mdp))
		dev_err(&ndev->dev, "Transmit Abort\n");
		}
		}

		if (intr_status & EESR_RABT) {
		/* Receive Abort int */