Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4e63959e authored by Jacek Anaszewski's avatar Jacek Anaszewski Committed by Mauro Carvalho Chehab
Browse files

[media] s5k6a3: Fix VIDIOC_SUBDEV_G_FMT ioctl for TRY format 



VIDIOC_SUBDEV_G_FMT ioctl should return TRY format previously
set with VIDIOC_SUBDEV_S_FMT. Currently it is not the case as
only ACTIVE formats are saved in the driver. Since the driver
doesn't alter hardware state in the set_fmt op anyway, the
op can save the format in both TRY and ACTIVE case.

Signed-off-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
Acked-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 76a56367

drivers/media/i2c/s5k6a3.c

+1 −2
Original line number Diff line number Diff line
@@ -144,7 +144,6 @@ static int s5k6a3_set_fmt(struct v4l2_subdev *sd, 
	mf = __s5k6a3_get_format(sensor, cfg, fmt->pad, fmt->which);

	if (mf) {

		mutex_lock(&sensor->lock);

		if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE)

		*mf = fmt->format;

		mutex_unlock(&sensor->lock);

	}