Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4e4f485c authored by Julia Lawall's avatar Julia Lawall Committed by Stephen Boyd
Browse files

clk: tegra: delete unneeded of_node_put

for_each_child_of_node performs an of_node_put on each iteration, so
putting an of_node_put before a continue results in a double put.

The semantic match that finds this problem is as follows
(http://coccinelle.lip6.fr

):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_get(child)
*  of_node_put(child);
   ...
*  continue;
}
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
parent 67d7188a
Loading
Loading
Loading
Loading
+1 −3
Original line number Original line Diff line number Diff line
@@ -491,10 +491,8 @@ struct clk *tegra_clk_register_emc(void __iomem *base, struct device_node *np,
	for_each_child_of_node(np, node) {
	for_each_child_of_node(np, node) {
		err = of_property_read_u32(node, "nvidia,ram-code",
		err = of_property_read_u32(node, "nvidia,ram-code",
					   &node_ram_code);
					   &node_ram_code);
		if (err) {
		if (err)
			of_node_put(node);
			continue;
			continue;
		}


		/*
		/*
		 * Store timings for all ram codes as we cannot read the
		 * Store timings for all ram codes as we cannot read the