Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d67d860 authored by Thomas Meyer's avatar Thomas Meyer Committed by Linus Torvalds
Browse files

mm: use kcalloc() instead of kzalloc() to allocate array 

The advantage of kcalloc is, that will prevent integer overflows which
could result from the multiplication of number of elements and size and
it is also a bit nicer to read.

The semantic patch that makes this change is available in
https://lkml.org/lkml/2011/11/25/107



Signed-off-by: default avatarThomas Meyer <thomas@m3y3r.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent f6238818

mm/vmalloc.c

+2 −2
Original line number Diff line number Diff line
@@ -2375,8 +2375,8 @@ struct vm_struct **pcpu_get_vm_areas(const unsigned long *offsets, 
		return NULL;

	}



	vms = kzalloc(sizeof(vms[0]) * nr_vms, GFP_KERNEL);

	vas = kzalloc(sizeof(vas[0]) * nr_vms, GFP_KERNEL);

	vms = kcalloc(nr_vms, sizeof(vms[0]), GFP_KERNEL);

	vas = kcalloc(nr_vms, sizeof(vas[0]), GFP_KERNEL);

	if (!vas || !vms)

		goto err_free2;