Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d370b74 authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Tomi Valkeinen
Browse files

fbdev: broadsheetfb: fix memory leak 



We have requested the firmware and it was loaded but we missed releasing
it both on success and error.

Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 4bdb4629

drivers/video/fbdev/broadsheetfb.c

+5 −3
Original line number Diff line number Diff line
@@ -752,7 +752,7 @@ static ssize_t broadsheet_loadstore_waveform(struct device *dev, 
	if ((fw_entry->size < 8*1024) || (fw_entry->size > 64*1024)) {

		dev_err(dev, "Invalid waveform\n");

		err = -EINVAL;

		goto err_failed;

		goto err_fw;

	}



	mutex_lock(&(par->io_lock));
@@ -762,13 +762,15 @@ static ssize_t broadsheet_loadstore_waveform(struct device *dev, 
	mutex_unlock(&(par->io_lock));

	if (err < 0) {

		dev_err(dev, "Failed to store broadsheet waveform\n");

		goto err_failed;

		goto err_fw;

	}



	dev_info(dev, "Stored broadsheet waveform, size %zd\n", fw_entry->size);



	return len;

	err = len;



err_fw:

	release_firmware(fw_entry);

err_failed:

	return err;

}