Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d3583cd authored by Javier Martinez Canillas's avatar Javier Martinez Canillas Committed by Eduardo Valentin
Browse files

thermal: exynos: Use devm_regulator_get_optional() for vtmu 



The Exynos TMU DT binding says that the vtmu-supply is optional but the
driver uses devm_regulator_get() that creates a dummy regulator if it's
not defined in the DT. For example the following message is in the log:

10060000.tmu supply vtmu not found, using dummy regulator

Use the optional version of regulator_get() that doesn't create a dummy
regulator and instead returns a -ENODEV errno code. Since it's expected
that a regulator may not be defined and the driver will inform about it:

exynos-tmu 10060000.tmu: Regulator node (vtmu) not found

Reviewed-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: default avatarAndi Shyti <andi.shyti@samsung.com>
Signed-off-by: default avatarJavier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: default avatarEduardo Valentin <edubezval@gmail.com>
parent 7bc40ddf

drivers/thermal/samsung/exynos_tmu.c

+1 −1
Original line number Diff line number Diff line
@@ -1310,7 +1310,7 @@ static int exynos_tmu_probe(struct platform_device *pdev) 
	 * TODO: Add regulator as an SOC feature, so that regulator enable

	 * is a compulsory call.

	 */

	data->regulator = devm_regulator_get(&pdev->dev, "vtmu");

	data->regulator = devm_regulator_get_optional(&pdev->dev, "vtmu");

	if (!IS_ERR(data->regulator)) {

		ret = regulator_enable(data->regulator);

		if (ret) {