Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d21cef3 authored by David Hildenbrand's avatar David Hildenbrand Committed by Cornelia Huck
Browse files

KVM: s390: vsie: fix riccbd 



We store the address of riccbd at the wrong location, overwriting
gvrd. This means that our nested guest will not be able to use runtime
instrumentation. Also, a memory leak, if our KVM guest actually sets gvrd.

Not noticed until now, as KVM guests never make use of gvrd and runtime
instrumentation wasn't completely tested yet.

Reported-by: default avatarFan Zhang <zhangfan@linux.vnet.ibm.com>
Reviewed-by: default avatarCornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: default avatarDavid Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: default avatarCornelia Huck <cornelia.huck@de.ibm.com>
parent 20b8f9e2

arch/s390/kvm/vsie.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -584,7 +584,7 @@ static int pin_blocks(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page) 
		/* Validity 0x0044 will be checked by SIE */

		/* Validity 0x0044 will be checked by SIE */

		if (rc)

		if (rc)

			goto unpin;

			goto unpin;

		scb_s->gvrd = hpa;

		scb_s->riccbd = hpa;

	}

	}

	return 0;

	return 0;

unpin:

unpin: