Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d1cdbf6 authored by Stephen Warren's avatar Stephen Warren Committed by Samuel Ortiz
Browse files

mfd: Remove tps6586x device ID check 



... and convert it to a dev_info print at probe time.

There are many variants of this chip with different values of VERSIONCRC.
The set of values is large, and not useful to enumerate. All are SW
compatible. The difference lies in default settings of the various power
rails, and other similar differences. The driver, or clients of the
driver, shouldn't be affected by this, since all rails should be
programmed into the desired state in all cases for correct operation.

Derived-from-code-by: default avatarAndrew Chew <achew@nvidia.com>
Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 5b9cecd6

drivers/mfd/tps6586x.c

+1 −7
Original line number Diff line number Diff line
@@ -46,8 +46,6 @@ 


/* device id */

#define TPS6586X_VERSIONCRC	0xcd

#define TPS658621A_VERSIONCRC	0x15

#define TPS658621C_VERSIONCRC	0x2c



struct tps6586x_irq_data {

	u8	mask_reg;
@@ -498,11 +496,7 @@ static int __devinit tps6586x_i2c_probe(struct i2c_client *client, 
		return -EIO;

	}



	if ((ret != TPS658621A_VERSIONCRC) &&

	    (ret != TPS658621C_VERSIONCRC)) {

		dev_err(&client->dev, "Unsupported chip ID: %x\n", ret);

		return -ENODEV;

	}

	dev_info(&client->dev, "VERSIONCRC is %02x\n", ret);



	tps6586x = kzalloc(sizeof(struct tps6586x), GFP_KERNEL);

	if (tps6586x == NULL)