Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c90d971 authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik
Browse files

libata: disable pdev on all suspend events 



libata used disable pdev only on PM_EVENT_SUSPEND while re-enable pdev
unconditionally.  This was okay before ref-counted pdev enable update
but it now makes the pdev pinned after swsusp cycle (enabled twice but
disabled only once) and devres sanity check whines about it.

Fix it by unconditionally disabling pdev on all suspend events.

Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 5e5c74a5

drivers/ata/libata-core.c

+2 −3
Original line number Diff line number Diff line
@@ -6054,12 +6054,11 @@ int pci_test_config_bits(struct pci_dev *pdev, const struct pci_bits *bits) 
void ata_pci_device_do_suspend(struct pci_dev *pdev, pm_message_t mesg)

{

	pci_save_state(pdev);



	if (mesg.event == PM_EVENT_SUSPEND) {

	pci_disable_device(pdev);



	if (mesg.event == PM_EVENT_SUSPEND)

		pci_set_power_state(pdev, PCI_D3hot);

}

}



int ata_pci_device_do_resume(struct pci_dev *pdev)

{