Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c8cc55b authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt
Browse files

ktest: Fix off-by-one in config bisect result 



Because in perl the array size returned by $#arr, is the last
index and not the actually size of the array, we end the config
bisect early, thinking there is only one config left when there
are in fact two. Thus the result has a 50% chance of picking
the correct config that caused the problem.

Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent 55922c9d

tools/testing/ktest/ktest.pl

+2 −2
Original line number Diff line number Diff line
@@ -1638,7 +1638,7 @@ sub run_config_bisect { 
	if (!$found) {

	    # try the other half

	    doprint "Top half produced no set configs, trying bottom half\n";

	    @tophalf = @start_list[$half .. $#start_list];

	    @tophalf = @start_list[$half + 1 .. $#start_list];

	    create_config @tophalf;

	    read_current_config \%current_config;

	    foreach my $config (@tophalf) {
@@ -1690,7 +1690,7 @@ sub run_config_bisect { 
	# remove half the configs we are looking at and see if

	# they are good.

	$half = int($#start_list / 2);

    } while ($half > 0);

    } while ($#start_list > 0);



    # we found a single config, try it again unless we are running manually