Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c5fba3d authored by Christian Ruppert's avatar Christian Ruppert Committed by Linus Walleij
Browse files

pinctrl/TB10x: Fix signedness bug 



In the TB10x pin database, a port index of -1 is used to indicate
unmuxed GPIO pin groups. This bug fixes a 'cast to unsigned' bug of
this value.

Thanks to Dan Carpenter for highlighting this.

CC: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarChristian Ruppert <christian.ruppert@abilis.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent a798c10f

drivers/pinctrl/pinctrl-tb10x.c

+1 −2
Original line number Diff line number Diff line
@@ -629,9 +629,8 @@ static int tb10x_gpio_request_enable(struct pinctrl_dev *pctl, 
	 */

	for (i = 0; i < state->pinfuncgrpcnt; i++) {

		const struct tb10x_pinfuncgrp *pfg = &state->pingroups[i];

		unsigned int port = pfg->port;

		unsigned int mode = pfg->mode;

		int j;

		int j, port = pfg->port;



		/*

		 * Skip pin groups which are always mapped and don't need