Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4bb13abf authored by Michael Chan's avatar Michael Chan Committed by David S. Miller
Browse files

bnxt_en: Add unsupported SFP+ module warnings. 



Add the PORT_CONN_NOT_ALLOWED async event handling logic.  The driver
will print an appropriate warning to reflect the SFP+ module enforcement
policy done in the firmware.

Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 25be8623

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+55 −0
Original line number Diff line number Diff line
@@ -121,6 +121,7 @@ static const u16 bnxt_vf_req_snif[] = { 
static const u16 bnxt_async_events_arr[] = {

	HWRM_ASYNC_EVENT_CMPL_EVENT_ID_LINK_STATUS_CHANGE,

	HWRM_ASYNC_EVENT_CMPL_EVENT_ID_PF_DRVR_UNLOAD,

	HWRM_ASYNC_EVENT_CMPL_EVENT_ID_PORT_CONN_NOT_ALLOWED,

};



static bool bnxt_vf_pciid(enum board_idx idx)
@@ -1236,6 +1237,19 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_napi *bnapi, u32 *raw_cons, 
	return rc;

}



#define BNXT_GET_EVENT_PORT(data)	\

	((data) &				\

	 HWRM_ASYNC_EVENT_CMPL_PORT_CONN_NOT_ALLOWED_EVENT_DATA1_PORT_ID_MASK)



#define BNXT_EVENT_POLICY_MASK	\

	HWRM_ASYNC_EVENT_CMPL_PORT_CONN_NOT_ALLOWED_EVENT_DATA1_ENFORCEMENT_POLICY_MASK



#define BNXT_EVENT_POLICY_SFT	\

	HWRM_ASYNC_EVENT_CMPL_PORT_CONN_NOT_ALLOWED_EVENT_DATA1_ENFORCEMENT_POLICY_SFT



#define BNXT_GET_EVENT_POLICY(data)	\

	(((data) & BNXT_EVENT_POLICY_MASK) >> BNXT_EVENT_POLICY_SFT)



static int bnxt_async_event_process(struct bnxt *bp,

				    struct hwrm_async_event_cmpl *cmpl)

{
@@ -1249,6 +1263,22 @@ static int bnxt_async_event_process(struct bnxt *bp, 
	case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_PF_DRVR_UNLOAD:

		set_bit(BNXT_HWRM_PF_UNLOAD_SP_EVENT, &bp->sp_event);

		break;

	case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_PORT_CONN_NOT_ALLOWED: {

		u32 data1 = le32_to_cpu(cmpl->event_data1);

		u16 port_id = BNXT_GET_EVENT_PORT(data1);



		if (BNXT_VF(bp))

			break;



		if (bp->pf.port_id != port_id)

			break;



		bp->link_info.last_port_module_event =

			BNXT_GET_EVENT_POLICY(data1);



		set_bit(BNXT_HWRM_PORT_MODULE_SP_EVENT, &bp->sp_event);

		break;

	}

	default:

		netdev_err(bp->dev, "unhandled ASYNC event (id 0x%x)\n",

			   event_id);
@@ -5447,6 +5477,28 @@ static void bnxt_timer(unsigned long data) 
	mod_timer(&bp->timer, jiffies + bp->current_interval);

}



static void bnxt_port_module_event(struct bnxt *bp)

{

	struct bnxt_link_info *link_info = &bp->link_info;

	struct hwrm_port_phy_qcfg_output *resp = &link_info->phy_qcfg_resp;



	if (bnxt_update_link(bp, true))

		return;



	if (link_info->last_port_module_event != 0) {

		netdev_warn(bp->dev, "Unqualified SFP+ module detected on port %d\n",

			    bp->pf.port_id);

		if (bp->hwrm_spec_code >= 0x10201) {

			netdev_warn(bp->dev, "Module part number %s\n",

				    resp->phy_vendor_partnumber);

		}

	}

	if (link_info->last_port_module_event == 1)

		netdev_warn(bp->dev, "TX is disabled\n");

	if (link_info->last_port_module_event == 3)

		netdev_warn(bp->dev, "Shutdown SFP+ module\n");

}



static void bnxt_cfg_ntp_filters(struct bnxt *);



static void bnxt_sp_task(struct work_struct *work)
@@ -5494,6 +5546,9 @@ static void bnxt_sp_task(struct work_struct *work) 
		rtnl_unlock();

	}



	if (test_and_clear_bit(BNXT_HWRM_PORT_MODULE_SP_EVENT, &bp->sp_event))

		bnxt_port_module_event(bp);



	if (test_and_clear_bit(BNXT_PERIODIC_STATS_SP_EVENT, &bp->sp_event))

		bnxt_hwrm_port_qstats(bp);

drivers/net/ethernet/broadcom/bnxt/bnxt.h

+3 −0
Original line number Diff line number Diff line
@@ -825,6 +825,8 @@ struct bnxt_link_info { 
	u16			req_link_speed;

	u32			advertising;

	bool			force_link_chng;



	u8			last_port_module_event;

	/* a copy of phy_qcfg output used to report link

	 * info to VF

	 */
@@ -992,6 +994,7 @@ struct bnxt { 
#define BNXT_RST_RING_SP_EVENT		7

#define BNXT_HWRM_PF_UNLOAD_SP_EVENT	8

#define BNXT_PERIODIC_STATS_SP_EVENT	9

#define BNXT_HWRM_PORT_MODULE_SP_EVENT	10



	struct bnxt_pf_info	pf;

#ifdef CONFIG_BNXT_SRIOV