Commit 4a28a3fa authored Jul 27, 2011 by Dan Carpenter Committed by Nicholas Bellinger Jul 27, 2011

iscsi-target: Fix NULL dereference on allocation failure



This patch fixes a bug in iscsi_target_init_negotiation() where
the "goto out" path dereferences "login" which is NULL upon a
memory allocation failure.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 277c5f27

drivers/target/iscsi/iscsi_target_nego.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -978,7 +978,7 @@ struct iscsi_login *iscsi_target_init_negotiation(
		pr_err("Unable to allocate memory for struct iscsi_login.\n");
		iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR,
		ISCSI_LOGIN_STATUS_NO_RESOURCES);
		goto out;
		return NULL;
		}

		login->req = kzalloc(ISCSI_HDR_LEN, GFP_KERNEL);