Commit 49fb88af authored Jun 18, 2009 by Marek Szyprowski Committed by Ben Dooks Jun 22, 2009

[ARM] S3C: Fix gpio-config off-by-one bug



Fix gpio-config off-by-one bug. Without this patch, touching GPA0 pin on
S3C64XX platform causes kernel oops.

Reviewed-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>

parent 0b495737

arch/arm/plat-s3c/gpio-config.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -119,7 +119,7 @@ int s3c_gpio_setcfg_s3c64xx_4bit(struct s3c_gpio_chip *chip,
	unsigned int shift = (off & 7) * 4;		unsigned int shift = (off & 7) * 4;
	u32 con;		u32 con;

	if (off < 8 && chip->chip.ngpio >= 8)		if (off < 8 && chip->chip.ngpio > 8)
	reg -= 4;		reg -= 4;

	if (s3c_gpio_is_cfg_special(cfg)) {		if (s3c_gpio_is_cfg_special(cfg)) {