Commit 49682864 authored Oct 05, 2009 by Valentine Barshak Committed by David S. Miller Oct 07, 2009

pasemi_mac: ethtool get settings fix



Not all pasemi mac interfaces can have a phy attached.
For example, XAUI has no phy and phydev is NULL for it.
In this case ethtool get settings causes kernel crash.
Fix it by returning -EOPNOTSUPP if there's no PHY attached.

Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
Acked-by: Olof Johansson <olof@lixom.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6e43650c

drivers/net/pasemi_mac_ethtool.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -71,6 +71,9 @@ pasemi_mac_ethtool_get_settings(struct net_device *netdev,
		struct pasemi_mac *mac = netdev_priv(netdev);
		struct phy_device *phydev = mac->phydev;

		if (!phydev)
		return -EOPNOTSUPP;

		return phy_ethtool_gset(phydev, cmd);
		}