Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4949603a authored by Markus Trippelsdorf's avatar Markus Trippelsdorf Committed by Borislav Petkov
Browse files

EDAC: Remove debugging output in scrub rate handling 



This patch removes superfluous debugging output in the sysfs scrub rate
handler. It also consolidates the error handling in the scrub rate
accessors.

Signed-off-by: default avatarMarkus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: default avatarBorislav Petkov <borislav.petkov@amd.com>
parent f0e615c3

drivers/edac/amd64_edac.c

+0 −2
Original line number Diff line number Diff line
@@ -211,8 +211,6 @@ static int amd64_get_scrub_rate(struct mem_ctl_info *mci) 


	scrubval = scrubval & 0x001F;



	amd64_debug("pci-read, sdram scrub control value: %d\n", scrubval);



	for (i = 0; i < ARRAY_SIZE(scrubrates); i++) {

		if (scrubrates[i].scrubval == scrubval) {

			retval = scrubrates[i].bandwidth;

drivers/edac/edac_mc_sysfs.c

+5 −6
Original line number Diff line number Diff line
@@ -458,13 +458,13 @@ static ssize_t mci_sdram_scrub_rate_store(struct mem_ctl_info *mci, 
		return -EINVAL;



	new_bw = mci->set_sdram_scrub_rate(mci, bandwidth);

	if (new_bw >= 0) {

		edac_printk(KERN_DEBUG, EDAC_MC, "Scrub rate set to %d\n", new_bw);

		return count;

	if (new_bw < 0) {

		edac_printk(KERN_WARNING, EDAC_MC,

			    "Error setting scrub rate to: %lu\n", bandwidth);

		return -EINVAL;

	}



	edac_printk(KERN_DEBUG, EDAC_MC, "Error setting scrub rate to: %lu\n", bandwidth);

	return -EINVAL;

	return count;

}



/*
@@ -483,7 +483,6 @@ static ssize_t mci_sdram_scrub_rate_show(struct mem_ctl_info *mci, char *data) 
		return bandwidth;

	}



	edac_printk(KERN_DEBUG, EDAC_MC, "Read scrub rate: %d\n", bandwidth);

	return sprintf(data, "%d\n", bandwidth);

}