Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4929fd8c authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller
Browse files

ip_tunnel: delete unneeded call to netdev_priv 

Netdev_priv is an accessor function, and has no purpose if its result is
not used.

A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@ local idexpression x; @@
-x = netdev_priv(...);
... when != x
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 688c3b00

net/ipv4/ip_tunnel.c

+1 −2
Original line number Diff line number Diff line
@@ -395,11 +395,10 @@ static struct ip_tunnel *ip_tunnel_create(struct net *net, 
					  struct ip_tunnel_net *itn,

					  struct ip_tunnel_parm *parms)

{

	struct ip_tunnel *nt, *fbt;

	struct ip_tunnel *nt;

	struct net_device *dev;



	BUG_ON(!itn->fb_tunnel_dev);

	fbt = netdev_priv(itn->fb_tunnel_dev);

	dev = __ip_tunnel_create(net, itn->fb_tunnel_dev->rtnl_link_ops, parms);

	if (IS_ERR(dev))

		return ERR_CAST(dev);