Commit 48f8f711 authored Mar 12, 2014 by Abhi Das Committed by Steven Whitehouse Mar 12, 2014

GFS2: check NULL return value in gfs2_ok_to_move



gfs2_lookupi() can return NULL if the path to the root is broken by
another rename/rmdir. In this case gfs2_ok_to_move() must check for
this NULL pointer and return error.

Resolves: rhbz#1060246
Signed-off-by: Abhi Das <adas@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

parent cb94eb06

fs/gfs2/inode.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1299,6 +1299,10 @@ static int gfs2_ok_to_move(struct gfs2_inode this, struct gfs2_inode to)
		}

		tmp = gfs2_lookupi(dir, &gfs2_qdotdot, 1);
		if (!tmp) {
		error = -ENOENT;
		break;
		}
		if (IS_ERR(tmp)) {
		error = PTR_ERR(tmp);
		break;