Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48c1699d authored by Johan Hovold's avatar Johan Hovold Committed by David S. Miller
Browse files

of_mdio: fix node leak in of_phy_register_fixed_link error path 



Make sure to drop the of_node reference also on failure to parse the
speed property in of_phy_register_fixed_link().

Fixes: 3be2a49e ("of: provide a binding for fixed link PHYs")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cfc44a4d

drivers/of/of_mdio.c

+4 −1
Original line number Diff line number Diff line
@@ -456,8 +456,11 @@ int of_phy_register_fixed_link(struct device_node *np) 
		status.link = 1;

		status.duplex = of_property_read_bool(fixed_link_node,

						      "full-duplex");

		if (of_property_read_u32(fixed_link_node, "speed", &status.speed))

		if (of_property_read_u32(fixed_link_node, "speed",

					 &status.speed)) {

			of_node_put(fixed_link_node);

			return -EINVAL;

		}

		status.pause = of_property_read_bool(fixed_link_node, "pause");

		status.asym_pause = of_property_read_bool(fixed_link_node,

							  "asym-pause");