Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48a3e950 authored by Cornelia Huck's avatar Cornelia Huck Committed by Marcelo Tosatti
Browse files

KVM: s390: Add support for machine checks. 



Add support for injecting machine checks (only repressible
conditions for now).

This is a bit more involved than I/O interrupts, for these reasons:

- Machine checks come in both floating and cpu varieties.
- We don't have a bit for machine checks enabling, but have to use
  a roundabout approach with trapping PSW changing instructions and
  watching for opened machine checks.

Reviewed-by: default avatarAlexander Graf <agraf@suse.de>
Reviewed-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: default avatarCornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
parent d8346b7d

Documentation/virtual/kvm/api.txt

+4 −0
Original line number Diff line number Diff line
@@ -2073,6 +2073,10 @@ KVM_S390_INT_IO(ai,cssid,ssid,schid) (vm) - compound value to indicate an 
    I/O interrupt (ai - adapter interrupt; cssid,ssid,schid - subchannel);

    I/O interruption parameters in parm (subchannel) and parm64 (intparm,

    interruption subclass)

KVM_S390_MCHK (vm, vcpu) - machine check interrupt; cr 14 bits in parm,

                           machine check interrupt code in parm64 (note that

                           machine checks needing further payload are not

                           supported by this ioctl)



Note that the vcpu ioctl is asynchronous to vcpu execution.

arch/s390/include/asm/kvm_host.h

+8 −0
Original line number Diff line number Diff line
@@ -75,8 +75,10 @@ struct kvm_s390_sie_block { 
	__u8	reserved40[4];		/* 0x0040 */

#define LCTL_CR0	0x8000

#define LCTL_CR6	0x0200

#define LCTL_CR14	0x0002

	__u16   lctl;			/* 0x0044 */

	__s16	icpua;			/* 0x0046 */

#define ICTL_LPSW 0x00400000

	__u32	ictl;			/* 0x0048 */

	__u32	eca;			/* 0x004c */

	__u8	icptcode;		/* 0x0050 */
@@ -187,6 +189,11 @@ struct kvm_s390_emerg_info { 
	__u16 code;

};



struct kvm_s390_mchk_info {

	__u64 cr14;

	__u64 mcic;

};



struct kvm_s390_interrupt_info {

	struct list_head list;

	u64	type;
@@ -197,6 +204,7 @@ struct kvm_s390_interrupt_info { 
		struct kvm_s390_emerg_info emerg;

		struct kvm_s390_extcall_info extcall;

		struct kvm_s390_prefix_info prefix;

		struct kvm_s390_mchk_info mchk;

	};

};

arch/s390/kvm/intercept.c

+2 −0
Original line number Diff line number Diff line
@@ -97,10 +97,12 @@ static int handle_lctl(struct kvm_vcpu *vcpu) 


static const intercept_handler_t instruction_handlers[256] = {

	[0x01] = kvm_s390_handle_01,

	[0x82] = kvm_s390_handle_lpsw,

	[0x83] = kvm_s390_handle_diag,

	[0xae] = kvm_s390_handle_sigp,

	[0xb2] = kvm_s390_handle_b2,

	[0xb7] = handle_lctl,

	[0xb9] = kvm_s390_handle_b9,

	[0xe5] = kvm_s390_handle_e5,

	[0xeb] = handle_lctlg,

};

arch/s390/kvm/interrupt.c

+112 −0
Original line number Diff line number Diff line
@@ -41,6 +41,11 @@ static int psw_ioint_disabled(struct kvm_vcpu *vcpu) 
	return !(vcpu->arch.sie_block->gpsw.mask & PSW_MASK_IO);

}



static int psw_mchk_disabled(struct kvm_vcpu *vcpu)

{

	return !(vcpu->arch.sie_block->gpsw.mask & PSW_MASK_MCHECK);

}



static int psw_interrupts_disabled(struct kvm_vcpu *vcpu)

{

	if ((vcpu->arch.sie_block->gpsw.mask & PSW_MASK_PER) ||
@@ -82,6 +87,12 @@ static int __interrupt_is_deliverable(struct kvm_vcpu *vcpu, 
	case KVM_S390_SIGP_SET_PREFIX:

	case KVM_S390_RESTART:

		return 1;

	case KVM_S390_MCHK:

		if (psw_mchk_disabled(vcpu))

			return 0;

		if (vcpu->arch.sie_block->gcr[14] & inti->mchk.cr14)

			return 1;

		return 0;

	case KVM_S390_INT_IO_MIN...KVM_S390_INT_IO_MAX:

		if (psw_ioint_disabled(vcpu))

			return 0;
@@ -116,6 +127,7 @@ static void __reset_intercept_indicators(struct kvm_vcpu *vcpu) 
		CPUSTAT_IO_INT | CPUSTAT_EXT_INT | CPUSTAT_STOP_INT,

		&vcpu->arch.sie_block->cpuflags);

	vcpu->arch.sie_block->lctl = 0x0000;

	vcpu->arch.sie_block->ictl &= ~ICTL_LPSW;

}



static void __set_cpuflag(struct kvm_vcpu *vcpu, u32 flag)
@@ -139,6 +151,12 @@ static void __set_intercept_indicator(struct kvm_vcpu *vcpu, 
	case KVM_S390_SIGP_STOP:

		__set_cpuflag(vcpu, CPUSTAT_STOP_INT);

		break;

	case KVM_S390_MCHK:

		if (psw_mchk_disabled(vcpu))

			vcpu->arch.sie_block->ictl |= ICTL_LPSW;

		else

			vcpu->arch.sie_block->lctl |= LCTL_CR14;

		break;

	case KVM_S390_INT_IO_MIN...KVM_S390_INT_IO_MAX:

		if (psw_ioint_disabled(vcpu))

			__set_cpuflag(vcpu, CPUSTAT_IO_INT);
@@ -326,6 +344,32 @@ static void __do_deliver_interrupt(struct kvm_vcpu *vcpu, 
			exception = 1;

		break;



	case KVM_S390_MCHK:

		VCPU_EVENT(vcpu, 4, "interrupt: machine check mcic=%llx",

			   inti->mchk.mcic);

		trace_kvm_s390_deliver_interrupt(vcpu->vcpu_id, inti->type,

						 inti->mchk.cr14,

						 inti->mchk.mcic);

		rc = kvm_s390_vcpu_store_status(vcpu,

						KVM_S390_STORE_STATUS_PREFIXED);

		if (rc == -EFAULT)

			exception = 1;



		rc = put_guest_u64(vcpu, __LC_MCCK_CODE, inti->mchk.mcic);

		if (rc == -EFAULT)

			exception = 1;



		rc = copy_to_guest(vcpu, __LC_MCK_OLD_PSW,

				   &vcpu->arch.sie_block->gpsw, sizeof(psw_t));

		if (rc == -EFAULT)

			exception = 1;



		rc = copy_from_guest(vcpu, &vcpu->arch.sie_block->gpsw,

				     __LC_MCK_NEW_PSW, sizeof(psw_t));

		if (rc == -EFAULT)

			exception = 1;

		break;



	case KVM_S390_INT_IO_MIN...KVM_S390_INT_IO_MAX:

	{

		__u32 param0 = ((__u32)inti->io.subchannel_id << 16) |
@@ -588,6 +632,61 @@ void kvm_s390_deliver_pending_interrupts(struct kvm_vcpu *vcpu) 
	}

}



void kvm_s390_deliver_pending_machine_checks(struct kvm_vcpu *vcpu)

{

	struct kvm_s390_local_interrupt *li = &vcpu->arch.local_int;

	struct kvm_s390_float_interrupt *fi = vcpu->arch.local_int.float_int;

	struct kvm_s390_interrupt_info  *n, *inti = NULL;

	int deliver;



	__reset_intercept_indicators(vcpu);

	if (atomic_read(&li->active)) {

		do {

			deliver = 0;

			spin_lock_bh(&li->lock);

			list_for_each_entry_safe(inti, n, &li->list, list) {

				if ((inti->type == KVM_S390_MCHK) &&

				    __interrupt_is_deliverable(vcpu, inti)) {

					list_del(&inti->list);

					deliver = 1;

					break;

				}

				__set_intercept_indicator(vcpu, inti);

			}

			if (list_empty(&li->list))

				atomic_set(&li->active, 0);

			spin_unlock_bh(&li->lock);

			if (deliver) {

				__do_deliver_interrupt(vcpu, inti);

				kfree(inti);

			}

		} while (deliver);

	}



	if (atomic_read(&fi->active)) {

		do {

			deliver = 0;

			spin_lock(&fi->lock);

			list_for_each_entry_safe(inti, n, &fi->list, list) {

				if ((inti->type == KVM_S390_MCHK) &&

				    __interrupt_is_deliverable(vcpu, inti)) {

					list_del(&inti->list);

					deliver = 1;

					break;

				}

				__set_intercept_indicator(vcpu, inti);

			}

			if (list_empty(&fi->list))

				atomic_set(&fi->active, 0);

			spin_unlock(&fi->lock);

			if (deliver) {

				__do_deliver_interrupt(vcpu, inti);

				kfree(inti);

			}

		} while (deliver);

	}

}



int kvm_s390_inject_program_int(struct kvm_vcpu *vcpu, u16 code)

{

	struct kvm_s390_local_interrupt *li = &vcpu->arch.local_int;
@@ -641,6 +740,13 @@ int kvm_s390_inject_vm(struct kvm *kvm, 
	case KVM_S390_INT_EMERGENCY:

		kfree(inti);

		return -EINVAL;

	case KVM_S390_MCHK:

		VM_EVENT(kvm, 5, "inject: machine check parm64:%llx",

			 s390int->parm64);

		inti->type = s390int->type;

		inti->mchk.cr14 = s390int->parm; /* upper bits are not used */

		inti->mchk.mcic = s390int->parm64;

		break;

	case KVM_S390_INT_IO_MIN...KVM_S390_INT_IO_MAX:

		if (s390int->type & IOINT_AI_MASK)

			VM_EVENT(kvm, 5, "%s", "inject: I/O (AI)");
@@ -749,6 +855,12 @@ int kvm_s390_inject_vcpu(struct kvm_vcpu *vcpu, 
		inti->type = s390int->type;

		inti->emerg.code = s390int->parm;

		break;

	case KVM_S390_MCHK:

		VCPU_EVENT(vcpu, 5, "inject: machine check parm64:%llx",

			   s390int->parm64);

		inti->type = s390int->type;

		inti->mchk.mcic = s390int->parm64;

		break;

	case KVM_S390_INT_VIRTIO:

	case KVM_S390_INT_SERVICE:

	case KVM_S390_INT_IO_MIN...KVM_S390_INT_IO_MAX:

arch/s390/kvm/kvm-s390.h

+3 −0
Original line number Diff line number Diff line
@@ -106,6 +106,7 @@ int kvm_s390_handle_wait(struct kvm_vcpu *vcpu); 
enum hrtimer_restart kvm_s390_idle_wakeup(struct hrtimer *timer);

void kvm_s390_tasklet(unsigned long parm);

void kvm_s390_deliver_pending_interrupts(struct kvm_vcpu *vcpu);

void kvm_s390_deliver_pending_machine_checks(struct kvm_vcpu *vcpu);

int kvm_s390_inject_vm(struct kvm *kvm,

		struct kvm_s390_interrupt *s390int);

int kvm_s390_inject_vcpu(struct kvm_vcpu *vcpu,
@@ -117,6 +118,8 @@ int kvm_s390_inject_sigp_stop(struct kvm_vcpu *vcpu, int action); 
int kvm_s390_handle_b2(struct kvm_vcpu *vcpu);

int kvm_s390_handle_e5(struct kvm_vcpu *vcpu);

int kvm_s390_handle_01(struct kvm_vcpu *vcpu);

int kvm_s390_handle_b9(struct kvm_vcpu *vcpu);

int kvm_s390_handle_lpsw(struct kvm_vcpu *vcpu);



/* implemented in sigp.c */

int kvm_s390_handle_sigp(struct kvm_vcpu *vcpu);