Commit 4899b8b1 authored Oct 06, 2006 by Andrew Morton Committed by Linus Torvalds Oct 06, 2006

[PATCH] kauditd_thread warning fix



Squash this warning:

  kernel/audit.c: In function 'kauditd_thread':
  kernel/audit.c:367: warning: no return statement in function returning non-void

We might as test kthread_should_stop(), although it's not very pointful at
present.

The code which starts this thread looks racy - the kernel could start multiple
threads.

Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent d195412c

kernel/audit.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -340,7 +340,7 @@ static int kauditd_thread(void *dummy)
		{
		struct sk_buff *skb;

		while (1) {
		while (!kthread_should_stop()) {
		skb = skb_dequeue(&audit_skb_queue);
		wake_up(&audit_backlog_wait);
		if (skb) {
		@@ -369,6 +369,7 @@ static int kauditd_thread(void *dummy)
		remove_wait_queue(&kauditd_wait, &wait);
		}
		}
		return 0;
		}

		int audit_send_list(void *_dest)