Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4877c737 authored by Ian Campbell's avatar Ian Campbell Committed by Thomas Gleixner
Browse files

xen: Do not suspend IPI IRQs. 



In general the semantics of IPIs are that they are are expected to
continue functioning after dpm_suspend_noirq().

Specifically I have seen a deadlock between the callfunc IPI and the
stop machine used by xen's do_suspend() routine. If one CPU has already
called dpm_suspend_noirq() then there is a window where it can be sent
a callfunc IPI before all the other CPUs have entered stop_cpu().

If this happens then the first CPU ends up spinning in stop_cpu()
waiting for the other to rendezvous in state STOPMACHINE_PREPARE while
the other is spinning in csd_lock_wait().

Signed-off-by: default avatarIan Campbell <ian.campbell@citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: xen-devel@lists.xensource.com
LKML-Reference: <1280398595-29708-4-git-send-email-ian.campbell@citrix.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent ba461f09

drivers/xen/events.c

+1 −0
Original line number Diff line number Diff line
@@ -536,6 +536,7 @@ int bind_ipi_to_irqhandler(enum ipi_vector ipi, 
	if (irq < 0)

		return irq;



	irqflags |= IRQF_NO_SUSPEND;

	retval = request_irq(irq, handler, irqflags, devname, dev_id);

	if (retval != 0) {

		unbind_from_irq(irq);