Commit 47c5ba53 authored Oct 31, 2010 by Dmitry Torokhov Committed by Linus Torvalds Oct 31, 2010

Input: ir-keytable - fix uninitialized variable warning



We were forgetting to set up proper return value in success path causing
ir_getkeycode() to fail intermittently:

drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode':
drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used
uninitialized in this function

Reported-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 50440c6d

drivers/media/IR/ir-keytable.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -389,6 +389,8 @@ static int ir_getkeycode(struct input_dev *dev,
		ke->len = sizeof(entry->scancode);
		memcpy(ke->scancode, &entry->scancode, sizeof(entry->scancode));

		retval = 0;

		out:
		spin_unlock_irqrestore(&rc_tab->lock, flags);
		return retval;