Commit 45d04359 authored Jan 04, 2016 by Jacob Keller Committed by Jeff Kirsher Feb 17, 2016

i40e: avoid large memcpy by assigning struct



Assign the i40e_pf structure directly instead of using a large memcpy,
which avoids a sparse warning and lets the compiler optimize the copy
since it knows the size of the structure in advance.

Change-ID: I17604e23be2616521eb760290befcb767b52b3f7
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent c40918c3

drivers/net/ethernet/intel/i40e/i40e_debugfs.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -185,9 +185,11 @@ static ssize_t i40e_dbg_dump_write(struct file *filp,
		if (i40e_dbg_prep_dump_buf(pf, buflen)) {
		p = i40e_dbg_dump_buf;

		len = sizeof(struct i40e_pf);
		memcpy(p, pf, len);
		p += len;
		/* avoid use of memcpy here due to sparse warning
		* about copy size.
		*/
		((struct i40e_pf )p) = *pf;
		p += sizeof(struct i40e_pf);

		len = (sizeof(struct i40e_aq_desc)
		* pf->hw.aq.num_asq_entries);