Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44bdcb54 authored by Vasiliy Kulikov's avatar Vasiliy Kulikov Committed by Samuel Ortiz
Browse files

mfd: ab8500: world-writable debugfs register-* files 



Don't allow everybody to interact with hardware registers.

Signed-off-by: default avatarVasiliy Kulikov <segoon@openwall.com>
Acked-by: default avatarLinus Walleij <linus.walleij@stericsson.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 90c861c2

drivers/mfd/ab8500-debugfs.c

+3 −3
Original line number Diff line number Diff line
@@ -585,18 +585,18 @@ static int __devinit ab8500_debug_probe(struct platform_device *plf) 
		goto exit_destroy_dir;



	ab8500_bank_file = debugfs_create_file("register-bank",

		(S_IRUGO | S_IWUGO), ab8500_dir, &plf->dev, &ab8500_bank_fops);

		(S_IRUGO | S_IWUSR), ab8500_dir, &plf->dev, &ab8500_bank_fops);

	if (!ab8500_bank_file)

		goto exit_destroy_reg;



	ab8500_address_file = debugfs_create_file("register-address",

		(S_IRUGO | S_IWUGO), ab8500_dir, &plf->dev,

		(S_IRUGO | S_IWUSR), ab8500_dir, &plf->dev,

		&ab8500_address_fops);

	if (!ab8500_address_file)

		goto exit_destroy_bank;



	ab8500_val_file = debugfs_create_file("register-value",

		(S_IRUGO | S_IWUGO), ab8500_dir, &plf->dev, &ab8500_val_fops);

		(S_IRUGO | S_IWUSR), ab8500_dir, &plf->dev, &ab8500_val_fops);

	if (!ab8500_val_file)

		goto exit_destroy_address;