Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44a074ff authored by Fabio Estevam's avatar Fabio Estevam Committed by Linus Walleij
Browse files

pinctrl: samsung: Fix the pointer in PTR_ERR() 



PTR_ERR should access the value just tested by IS_ERR

The semantic patch that makes this change is available
in scripts/coccinelle/tests/odd_ptr_err.cocci.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 3944e7b7

drivers/pinctrl/samsung/pinctrl-samsung.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -806,7 +806,7 @@ static int samsung_pinctrl_parse_dt(struct platform_device *pdev, 
	functions = samsung_pinctrl_create_functions(dev, drvdata, &func_cnt);

	functions = samsung_pinctrl_create_functions(dev, drvdata, &func_cnt);

	if (IS_ERR(functions)) {

	if (IS_ERR(functions)) {

		dev_err(dev, "failed to parse pin functions\n");

		dev_err(dev, "failed to parse pin functions\n");

		return PTR_ERR(groups);

		return PTR_ERR(functions);

	}

	}





	drvdata->pin_groups = groups;

	drvdata->pin_groups = groups;