Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 444c6dd5 authored by Johan Hedberg's avatar Johan Hedberg Committed by Marcel Holtmann
Browse files

Bluetooth: Add clarifying comment to command status handling 



When dealing with HCI command status events, the reasoning for trying to
mark a request as complete if no specific event is being waited for and
status was success is not self-evident. This patch adds a clarifying
comment above the if-statement.

Signed-off-by: default avatarJohan Hedberg <johan.hedberg@intel.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 64dd374e

net/bluetooth/hci_event.c

+6 −0
Original line number Diff line number Diff line
@@ -3124,6 +3124,12 @@ static void hci_cmd_status_evt(struct hci_dev *hdev, struct sk_buff *skb) 
	if (ev->ncmd && !test_bit(HCI_RESET, &hdev->flags))

		atomic_set(&hdev->cmd_cnt, 1);



	/* Indicate request completion if the command failed. Also, if

	 * we're not waiting for a special event and we get a success

	 * command status we should try to flag the request as completed

	 * (since for this kind of commands there will not be a command

	 * complete event).

	 */

	if (ev->status ||

	    (hdev->sent_cmd && !bt_cb(hdev->sent_cmd)->req.event))

		hci_req_cmd_complete(hdev, opcode, ev->status);