Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4307d8f6 authored by Oded Gabbay's avatar Oded Gabbay
Browse files

amdkfd: Fix sparse warnings in kfd_chardev.c 



Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarOded Gabbay <oded.gabbay@amd.com>
parent 0a3d775f

drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

+12 −4
Original line number Diff line number Diff line
@@ -149,7 +149,9 @@ static int set_queue_properties_from_user(struct queue_properties *q_properties, 
	}



	if ((args->ring_base_address) &&

		(!access_ok(VERIFY_WRITE, args->ring_base_address, sizeof(uint64_t)))) {

		(!access_ok(VERIFY_WRITE,

			(const void __user *) args->ring_base_address,

			sizeof(uint64_t)))) {

		pr_err("kfd: can't access ring base address\n");

		return -EFAULT;

	}
@@ -159,12 +161,16 @@ static int set_queue_properties_from_user(struct queue_properties *q_properties, 
		return -EINVAL;

	}



	if (!access_ok(VERIFY_WRITE, args->read_pointer_address, sizeof(uint32_t))) {

	if (!access_ok(VERIFY_WRITE,

			(const void __user *) args->read_pointer_address,

			sizeof(uint32_t))) {

		pr_err("kfd: can't access read pointer\n");

		return -EFAULT;

	}



	if (!access_ok(VERIFY_WRITE, args->write_pointer_address, sizeof(uint32_t))) {

	if (!access_ok(VERIFY_WRITE,

			(const void __user *) args->write_pointer_address,

			sizeof(uint32_t))) {

		pr_err("kfd: can't access write pointer\n");

		return -EFAULT;

	}
@@ -325,7 +331,9 @@ static int kfd_ioctl_update_queue(struct file *filp, struct kfd_process *p, 
	}



	if ((args.ring_base_address) &&

		(!access_ok(VERIFY_WRITE, args.ring_base_address, sizeof(uint64_t)))) {

		(!access_ok(VERIFY_WRITE,

			(const void __user *) args.ring_base_address,

			sizeof(uint64_t)))) {

		pr_err("kfd: can't access ring base address\n");

		return -EFAULT;

	}