Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 42d77210 authored by Markus Elfring's avatar Markus Elfring Committed by Takashi Iwai
Browse files

ALSA: es1688_lib: Deletion of an unnecessary check before the function call... 


ALSA: es1688_lib: Deletion of an unnecessary check before the function call "release_and_free_resource"

The release_and_free_resource() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent d712eaf2

sound/isa/es1688/es1688_lib.c

+1 −2
Original line number Diff line number Diff line
@@ -614,7 +614,6 @@ static int snd_es1688_free(struct snd_es1688 *chip) 
{

	if (chip->hardware != ES1688_HW_UNDEF)

		snd_es1688_init(chip, 0);

	if (chip->res_port)

	release_and_free_resource(chip->res_port);

	if (chip->irq >= 0)

		free_irq(chip->irq, (void *) chip);