Commit 422485da authored Jul 08, 2016 by Florian Fainelli Committed by Brian Norris Jul 16, 2016

mtd: nand: brcmnand: Change BUG_ON in brcmnand_send_cmd



Change the BUG_ON() condition in brcmnand_send_cmd() which checks for
the interrupt status "controller ready" bit to a WARN_ON.

There is no good reason to kill the system when this condition occur
because we could have systems which listed the NAND controller as
available (e.g: from Device Tree), but the NAND chip could be
malfunctioning and not responding.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Brian Norris <computersforpeace@gmail.com>
Reviewed-by: Kamal Dasu <kdasu.kdev@gmail.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>

parent 79ad07d4

drivers/mtd/nand/brcmnand/brcmnand.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1165,7 +1165,7 @@ static void brcmnand_send_cmd(struct brcmnand_host *host, int cmd)
		ctrl->cmd_pending = cmd;

		intfc = brcmnand_read_reg(ctrl, BRCMNAND_INTFC_STATUS);
		BUG_ON(!(intfc & INTFC_CTLR_READY));
		WARN_ON(!(intfc & INTFC_CTLR_READY));

		mb(); /* flush previous writes */
		brcmnand_write_reg(ctrl, BRCMNAND_CMD_START,