Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41dfd908 authored by Viresh Kumar's avatar Viresh Kumar Committed by Rafael J. Wysocki
Browse files

cpufreq: propagate error returned by kobject_move() 



We are returning -EINVAL instead of the error returned from kobject_move() when
it fails. Propagate the actual error number.

Also add a meaningful print when sysfs_create_link() fails.

Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 1461dc7d

drivers/cpufreq/cpufreq.c

+5 −3
Original line number Diff line number Diff line
@@ -1322,10 +1322,12 @@ static int cpufreq_nominate_new_policy_cpu(struct cpufreq_policy *policy, 
	ret = kobject_move(&policy->kobj, &cpu_dev->kobj);

	if (ret) {

		pr_err("%s: Failed to move kobj: %d\n", __func__, ret);

		ret = sysfs_create_link(&cpu_dev->kobj, &policy->kobj,

					"cpufreq");



		return -EINVAL;

		if (sysfs_create_link(&cpu_dev->kobj, &policy->kobj, "cpufreq"))

			pr_err("%s: Failed to restore kobj link to cpu:%d\n",

			       __func__, cpu_dev->id);



		return ret;

	}



	return cpu_dev->id;